Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZonefileFmt trait for printing records as zonefiles #379

Merged
merged 22 commits into from
Oct 23, 2024
Merged

Add ZonefileFmt trait for printing records as zonefiles #379

merged 22 commits into from
Oct 23, 2024

Conversation

tertsdiepraam
Copy link
Contributor

@tertsdiepraam tertsdiepraam commented Aug 30, 2024 •
edited
Loading

No description provided.

@tertsdiepraam tertsdiepraam changed the title Add Present trait for printing records as zonefiles Add Show trait for printing records as zonefiles Sep 4, 2024
Philip-NLnetLabs
Philip-NLnetLabs reviewed Sep 4, 2024
View reviewed changes
src/base/show.rs Outdated Show resolved Hide resolved
@tertsdiepraam tertsdiepraam changed the title Add Show trait for printing records as zonefiles Add ZonefileFmt trait for printing records as zonefiles Sep 27, 2024
@tertsdiepraam tertsdiepraam force-pushed the ds-print-secalg-as-int branch 2 times, most recently from 74a73a5 to bd583c5 Compare September 27, 2024 12:20
@tertsdiepraam tertsdiepraam force-pushed the ds-print-secalg-as-int branch 2 times, most recently from 440cc9b to ccbdfb6 Compare September 27, 2024 12:53
@tertsdiepraam tertsdiepraam marked this pull request as ready for review September 27, 2024 13:03
bal-e
bal-e requested changes Sep 27, 2024
View reviewed changes
src/base/iana/macros.rs Show resolved Hide resolved
src/base/iana/macros.rs Outdated Show resolved Hide resolved
src/base/name/traits.rs Outdated Show resolved Hide resolved
src/base/opt/mod.rs Show resolved Hide resolved
src/base/show.rs Outdated Show resolved Hide resolved
src/base/iana/macros.rs Outdated Show resolved Hide resolved
src/base/name/traits.rs Show resolved Hide resolved
src/base/record.rs Outdated Show resolved Hide resolved
src/base/zonefile_fmt.rs Outdated Show resolved Hide resolved
src/rdata/dnssec.rs Outdated Show resolved Hide resolved
bal-e
bal-e reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@bal-e bal-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, @tertsdiepraam!

src/rdata/rfc1035/null.rs Show resolved Hide resolved
src/rdata/svcb/rdata.rs Show resolved Hide resolved
src/base/zonefile_fmt.rs Outdated Show resolved Hide resolved
bal-e
bal-e reviewed Oct 23, 2024
View reviewed changes
src/base/zonefile_fmt.rs Outdated Show resolved Hide resolved
@tertsdiepraam tertsdiepraam merged commit dee14bd into main Oct 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bal-e bal-e bal-e approved these changes

@partim partim Awaiting requested review from partim

@Philip-NLnetLabs Philip-NLnetLabs Awaiting requested review from Philip-NLnetLabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tertsdiepraam @partim @Philip-NLnetLabs @bal-e